Add unchecked_reference::operator() and operator[] to overload resolution of unchecked_mutable_reference #2514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of unchecked_mutable_reference
bstaletic
approved these changes
Sep 20, 2020
henryiii
approved these changes
Sep 21, 2020
|
Looks all good to me as well, thanks! |
wjakob
approved these changes
Oct 2, 2020
|
Thanks for logging this issue and for all the arguing on why this was missing, @MoritzMaxeiner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1468
Given that
unchecked_referenceis a public base, I think not considering these methods in the overload resolution was an oversight.I think we could indeed also add
constto these methods ofunchecked_mutable_reference(similar tostd::spanorstd::reference_wrapper), but this change is less controversial and should fix the most important use cases.