Skip to content

Update pybind11Tools.cmake #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2020
Merged

Update pybind11Tools.cmake #2419

merged 1 commit into from
Aug 21, 2020

Conversation

bjodah
Copy link
Contributor

@bjodah bjodah commented Aug 21, 2020

CPython configured with --with-pydebug could not use pybind11_add_module

@bjodah
Update pybind11Tools.cmake
e1bd8a3 
CPython configured with `--with-pydebug` could not use `pybind11_add_module`
@henryiii
Copy link
Collaborator

Fantastic! I just tried to build against a debug Python, hit this error, and there's a fix just waiting for me. +1! Thanks!

@henryiii henryiii merged commit d4d7ef5 into pybind:master Aug 21, 2020
@henryiii henryiii mentioned this pull request Aug 21, 2020
Merged
@bjodah
Copy link
Contributor Author

bjodah commented Aug 22, 2020

Thanks!

@bjodah bjodah deleted the patch-2 branch August 22, 2020 12:39
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjodah @henryiii