added py::ellipsis() method for slicing of multidimensional NumPy arrays #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Aug 28, 2018
| @@ -408,3 +408,7 @@ def test_array_create_and_resize(msg): | |||
| a = m.create_and_resize(2) | |||
| assert(a.size == 4) | |||
| assert(np.all(a == 42.)) | |||
|
|
|||
There was a problem hiding this comment.
Flake8 error in CI:
./tests/test_numpy_array.py:412:1: E302 expected 2 blank lines, found 1
def test_index_using_ellipsis():
ax3l
reviewed
Aug 28, 2018
tests/test_numpy_array.cpp
Outdated
| @@ -295,4 +295,8 @@ TEST_SUBMODULE(numpy_array, sm) { | |||
| std::fill(a.mutable_data(), a.mutable_data() + a.size(), 42.); | |||
| return a; | |||
| }); | |||
|
|
|||
| sm.def("index_using_ellipsis", [](py::array a) { | |||
| return a[py::make_tuple(0, py::ellipsis(), 0)]; | |||
There was a problem hiding this comment.
must be excluded in python 2 tests
This PR adds a new py::ellipsis() method which can be used in conjunction with NumPy's generalized slicing support. For instance, the following is now valid (where "a" is a NumPy array): py::array b = a[py::make_tuple(0, py::ellipsis(), 0)];
|
@ax3l : thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
py::ellipsis()method which can be used in conjunction with NumPy's generalized slicing support. For instance, the following is now valid (whereais a NumPy array):