stl.h: propagate return value policies to type-specific casters #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return value policies for containers like those handled in in 'stl.h' are currently broken. The problem is that detail::return_value_policy_override<C>::policy() always returns 'move' when given a non-pointer/reference type, e.g. 'std::vector<...>'. This is sensible behavior for custom types that are exposed via 'py::class_<>', but it does not make sense for types that are handled by other type casters (STL containers, Eigen matrices, etc.). This commit changes the behavior so that detail::return_value_policy_override only becomes active when the type caster derives from type_caster_generic. Furthermore, the override logic is called recursively in STL type casters to enable key/value-specific behavior.
jagerman
approved these changes
Jul 17, 2018
Member
jagerman
left a comment
jagerman
left a comment
There was a problem hiding this comment.
This looks good to me; the logic inversion on the override seems pretty sensible.
tests/test_stl.cpp
Outdated
| class Placeholder { | ||
| public: | ||
| Placeholder() { print_created(this); } | ||
| Placeholder(const Placeholder &) = delete;//{ print_created(this); } |
Member
Author
|
Thanks -- merged now. |
EricCousineau-TRI
added a commit
to EricCousineau-TRI/pybind11
that referenced
this pull request
Sep 3, 2018
…type-specific casters (pybind#1455)" This reverts commit cbd16a8.
EricCousineau-TRI
added a commit
to EricCousineau-TRI/pybind11
that referenced
this pull request
Sep 3, 2018
…rs (pybind#1455)" This reverts commit cbd16a8.
wjakob
added a commit
that referenced
this pull request
Sep 11, 2018
* stl.h: propagate return value policies to type-specific casters Return value policies for containers like those handled in in 'stl.h' are currently broken. The problem is that detail::return_value_policy_override<C>::policy() always returns 'move' when given a non-pointer/reference type, e.g. 'std::vector<...>'. This is sensible behavior for custom types that are exposed via 'py::class_<>', but it does not make sense for types that are handled by other type casters (STL containers, Eigen matrices, etc.). This commit changes the behavior so that detail::return_value_policy_override only becomes active when the type caster derives from type_caster_generic. Furthermore, the override logic is called recursively in STL type casters to enable key/value-specific behavior.
wojdyr
added a commit
to project-gemmi/gemmi
that referenced
this pull request
Sep 12, 2018
fix compatibility with pybind11 2.2.4 return type of SubCells.find_atoms() is now "opaque" vector of pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return value policies for containers like those handled in in 'stl.h'
are currently broken.
The problem is that detail::return_value_policy_override::policy()
always returns 'move' when given a non-pointer/reference type, e.g.
'std::vector<...>'.
This is sensible behavior for custom types that are exposed via
'py::class_<>', but it does not make sense for types that are handled by
other type casters (STL containers, Eigen matrices, etc.).
This commit changes the behavior so that
detail::return_value_policy_override only becomes active when the type
caster derives from type_caster_generic.
Furthermore, the override logic is called recursively in STL type
casters to enable key/value-specific behavior.