Skip to content

Fix cmake cxx standard definition #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix cmake cxx standard definition #1089

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96b37be
Fix cmake cxx standard definition
ppwwyyxx Sep 15, 2017
a146ba6
check cmake version>=3.3
ppwwyyxx Sep 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tools/pybind11Tools.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,12 @@ function(pybind11_add_module target_name)
endif()

# Make sure C++11/14 are enabled
target_compile_options(${target_name} PUBLIC ${PYBIND11_CPP_STANDARD})
if(CMAKE_VERSION VERSION_LESS 3.3.0)
target_compile_options(${target_name} PUBLIC ${PYBIND11_CPP_STANDARD})
else()
# use generator expression to make sure the flag only applies to CXX
target_compile_options(${target_name} PUBLIC $<$<COMPILE_LANGUAGE:CXX>:${PYBIND11_CPP_STANDARD}>)
endif()

if(ARG_NO_EXTRAS)
return()
Expand Down