Skip to content

Flaky timing Windows test in CI #2398

Closed
@henryiii

Description

@henryiii

There's occasionally a diff of a 1 second in the test that compares two times, mostly on Windows, probably due to the shared infrastructure. We should probably loosen it up just a bit, or maybe compute a bound by running the python clock both before and after, etc.

# Get the time from both c++ and datetime
date1 = m.test_chrono1()
date2 = datetime.datetime.today()
# The returned value should be a datetime
assert isinstance(date1, datetime.datetime)
# The numbers should vary by a very small amount (time it took to execute)
diff = abs(date1 - date2)
# There should never be a days/seconds difference
assert diff.days == 0
assert diff.seconds == 0
# We test that no more than about 0.5 seconds passes here
# This makes sure that the dates created are very close to the same
# but if the testing system is incredibly overloaded this should still pass
assert diff.microseconds < 500000

Metadata

Metadata

Assignees

No one assigned

    Labels

    ci flakeKnown CI issues. Failures on CI should be recorded in an issue, but not block PRs.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions