-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for template generation #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @santacodes! Looks good to me. Could you please add a minimal CI job to check if the tests are working fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @santacodes, Good Start I must admit :)
Some comments below to propose some improvements
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
Sorry for the delay @Saransh-cpp, I was travelling. I added CI for the tests, created a nox session for testing the template generation, and tested it on my branch. Could you please review and look at it? Also, I added uv to the nox backend, which seems to be faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @santacodes! Few minor changes below -
TODO:
|
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Hi, don't worry about the rules. I'll set them up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks @santacodes! I'll wait for @agriyakhetarpal and @arjxn-py's reviews.
Hi, I'll review this in a couple of hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better @santacodes 🙂, Some comments below for minor improvements, feel free to ping me again.
Before we merge, we would want that the workflow starts running on this same PR.
Plus, I really appreciate that we're also adapting to uv
in this.
xref PyBaMM#3825
Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com>
P.S. I'm sorry for the late review! I have been a bit out of touch, plus I noticed that Saransh and Arjun had already put in their reviews. I hope this is helpful. |
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
@arjxn-py can you please review my last commit, I actually modified those test cases completely because I think they're better in terms of assertions and we don't have to play with paths as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @santacodes, the tests look perfect to me now.
Before we merge, I'd just want to confirm if we can safely resolve the conversation about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as long as the tests pass – resolved the previous conversation. Thanks for adding this, @santacodes!
xrefs for uv
's caching to look at later: astral-sh/uv#2231, yezz123/setup-uv#25, actions/setup-python#822, actions/setup-python#818
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
(I think we should disable the setting that dismisses reviews on further commits) |
I'm merging this as @santacodes needs to start working on entrypoints as well. |
Yes, I was going to mention that reviews were getting dismissed automatically |
Description
pytest-cookies
.cookiecutter
as a dependency and setup___init.py__
for the src layout.