Repository navigation
Fix half-cell electrolyte lithium diagnostics - #5765
Merged
rtimms merged 5 commits intoSep 22, 2026
Merged
Conversation
Contributor
|
Bencher Report| Project | PyBaMM |
| Branch | codex/fix-half-cell-electrolyte-lithium |
| Testbed | bare-metal |
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5765 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 341 341
Lines 33787 33796 +9
=======================================
+ Hits 33164 33173 +9
Misses 623 623 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rtimms
marked this pull request as ready for review
September 22, 2026 09:46
BradyPlanden
approved these changes
Sep 22, 2026
rtimms
enabled auto-merge (squash)
September 22, 2026 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct half-cell electrolyte lithium inventory to integrate only the separator and working-electrode domains. This also corrects the initial electrolyte-lithium reference used by total-lithium and LLI diagnostics, and fixes the equivalent
BasicDFNHalfCelloutput. Regression tests assert direct physical mass for Xu2019 and downstream diagnostics.Fixes #5746
Checks
uv run --no-sync pytest -m unit packages/pybamm/tests/unit/test_models/test_full_battery_models/test_lithium_ion(642 passed, 12 pre-existing skips)uv run --no-sync pre-commit run --fileson all changed filesDraft pending the repository's complete test and documentation-check matrix.