Skip to content

Added OCP model to take temperature as input #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ksudhir111
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@ksudhir111 ksudhir111 requested a review from a team as a code owner May 14, 2025 15:58
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 98.46%. Comparing base (3d0d6ff) to head (6f2e46f).
Report is 106 commits behind head on develop.

Files with missing lines Patch % Lines
...ce/open_circuit_potential/rk_ocp_temp_dependent.py 0.00% 27 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5015      +/-   ##
===========================================
- Coverage    98.69%   98.46%   -0.23%     
===========================================
  Files          303      305       +2     
  Lines        23256    23683     +427     
===========================================
+ Hits         22953    23320     +367     
- Misses         303      363      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksudhir111 , this implementation looks good for the class itself but there are a few other steps required to make this useable within PyBaMM

  1. add an option to BatteryModelOptions for using this open-circuit potential model, then
  2. add a case to lithium_ion.BaseModel.set_open_circuit_potential_submodel to use this new submodel if the "rk" option is used for open-circuit potential
  3. add unit and integration tests
  4. add docs

See all the steps in https://github.com/pybamm-team/PyBaMM/pull/4816/files for guidance on where to make those changes

@aabills aabills self-requested a review May 16, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants