Open
Description
openedon Oct 17, 2024
While removing the deprecated MacOS-12 runners for GitHub actions, I ran into issues with IREE. The comments suggest that it should work with MacOS version 13, but the tests fail. It seems to work fine one MacOS-14 and Linux.
As a temporary fix, I suggested changed the version in PR #4520
if (not sys.version_info[:2] == (3, 11)) or mac_ver < 14:
warnings.warn(
(
"IREE is only supported on MacOS 13 (or higher) and Python"
"version 3.11. Setting PYBAMM_IDAKLU_EXPR_IREE=OFF."
),
stacklevel=2,
)
return "OFF"
A few other things I noticed while looking into the failures:
- Updating Jax, JaxLib, and IREE requires updating versions in multiple places which is not easy to maintain. This should be centralized somehow
- jax versions in
utils.py
andpyproject.toml
- IREE compiler versions are set in both
noxfile.py
andpyproject.toml
- jax versions in
- Newer versions of Jax/JaxLib have removed support for Python 3.9, so updating Jax and IREE could be difficult until we remove support for python 3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment