Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Add monthly downloads badge #16

Closed
wants to merge 1 commit into from

Conversation

ayushjain01
Copy link

Added a badge displaying the monthly download count from pip Trends. You can view more details at - https://piptrends.com/package/pyasn1-modules
There are more badges and widgets, you can view them here - https://piptrends.com/widgets/pyasn1-modules
(If necessary, the link from the badge to the package's pip Trends page can be removed. We just want to showcase a badge we have created.)

@ixmatus
Copy link

ixmatus commented Jun 27, 2024

A colleague of this person tried to open this exact PR against a project I'm the maintainer for as well (ixmatus/inflector#16). This is a promotional campaign and they (or colleagues) appear to be doing it on reddit too, I think this is suspicious activity. They are creating an external dependency on a web property that (as far as I can tell) is not officially blessed by pypi. I recommend rejecting this PR.

Users can get package statistics from libraries.io which is linked to directly by pypi itself.

@ayushjain01
Copy link
Author

Thank you for your feedback and concerns. I'd like to clarify that this is not a promotional campaign. As stated in the PR description, our intention is simply to share a tool we have developed, which we believe could be beneficial to the community.

Our badge system offers highly accurate statistics, which is why we wanted to make it available. If the link to the pip trends page is a concern, we are more than willing to remove it.

We respect your decision if you prefer not to add more badges to your README. Our primary goal is to address any misunderstandings and assure you that this is a genuine effort to contribute to the open-source community by sharing our work on GitHub.

Thank you for considering our contribution.

@tiran
Copy link

tiran commented Jul 1, 2024

I'm very suspicious as well and suggest to not land this PR.

@droideck droideck closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants