Implement Taiwanese Chinese localization #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! I will look this PR over and hopefully have some feedback for you soon. As a full disclosure, since I personally do not read Taiwanese Chinese, I will have to take some extra time by passing these strings through Google Translate just to make sure that there is no language which is unintentionally hurtful or harmful. Thank you! |
brlin-tw
force-pushed
the
patch/implement-zhrtw-localization
branch
2 times, most recently
from
eb564d1 to
b8f7e09
Compare
This patch provides user interface string translation in Taiwanese Chinese.
|
Note that currently there is a string interpolation error in the error details view:
|
brlin-tw
force-pushed
the
patch/implement-zhrtw-localization
branch
from
b8f7e09 to
a087141
Compare
pyamsoft
added a commit
that referenced
this pull request
Jul 1, 2024
I guess even from a different resource file, the same named string res ID can collide. Fun. Blank out the title to avoid the issue and reduce noise. Should address the comment in #310
|
Hi, sorry this has been taking so long. I have not forgotten, I have just been busy. I hope to have it reviewed and merged soon, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides user interface string translations in Taiwanese Chinese(as far as the current I18N implementation allows).
There are some UI strings that isn't translatable probably due to they're not marked as resource strings, or belong to another package(pydroid):