make all nowcast methods xarray compatible #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 9, 2024
mats-knmi
force-pushed
the
xarray/steps-nowcast
branch
from
2eaacf2 to
5eb0489
Compare
mats-knmi
force-pushed
the
xarray/steps-nowcast
branch
from
5eb0489 to
dc50885
Compare
mats-knmi
changed the title
mats-knmi
added a commit
that referenced
this pull request
Sep 2, 2024
* make test steps skill run * undo accidental change * make steps nowcast xarray compatible * wrap all nowcasts in xarray * fix dimension.py tests * update dimension.py to work with new dataarrays * fix test_nowcast_utils tests * update docs and make xarray usage more explicit in nowcasts * update docs and make xarray usage in motion methods more explicit
mats-knmi
added a commit
that referenced
this pull request
Sep 23, 2024
* make test steps skill run * undo accidental change * make steps nowcast xarray compatible * wrap all nowcasts in xarray * fix dimension.py tests * update dimension.py to work with new dataarrays * fix test_nowcast_utils tests * update docs and make xarray usage more explicit in nowcasts * update docs and make xarray usage in motion methods more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I editted all nowcast and motion methods so that they take in an xarray dataset and return one as well. I updated the relevant tests and they all succeed except for the callback tests, because that still depends on the outcome of #404.
The documentation of the datamodel is also updated to include the possible dimensions and data variables that can be contained in the resulting datasets.