Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some changes from #255 #271

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Revert some changes from #255 #271

merged 6 commits into from
Feb 18, 2022

Conversation

dnerini
Copy link
Member

@dnerini dnerini commented Feb 18, 2022

Some changes that were meant for #254 were wrongly included in #255. This PR tries to revert them.

@dnerini dnerini changed the title Revert changes from #255 Revert some changes from #255 Feb 18, 2022
Copy link
Member

@aperezhortal aperezhortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It looks to go after the tests passed.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #271 (ca57193) into master (8a65727) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   82.22%   82.23%   +0.01%     
==========================================
  Files         158      158              
  Lines       12088    12100      +12     
==========================================
+ Hits         9939     9951      +12     
  Misses       2149     2149              
Flag Coverage Δ
unit_tests 82.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/tests/helpers.py 94.28% <ø> (ø)
pysteps/utils/reprojection.py 87.87% <ø> (ø)
pysteps/io/importers.py 72.03% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a65727...ca57193. Read the comment docs.

@dnerini dnerini merged commit a9e4cc8 into master Feb 18, 2022
@dnerini dnerini deleted the revert-changes branch February 18, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants