Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title from colorbar #260

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Remove title from colorbar #260

merged 1 commit into from
Jan 27, 2022

Conversation

dnerini
Copy link
Member

@dnerini dnerini commented Jan 26, 2022

So far we indicated the units of the colorbar as its title. However, this keeps overlapping with the colorbar itself. The easiest fix is to remove the title and add the units to the label instead.

And units to its lable instead
@dnerini dnerini self-assigned this Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #260 (7fe6e2a) into master (10540d2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   80.92%   80.92%   -0.01%     
==========================================
  Files         142      142              
  Lines       10760    10758       -2     
==========================================
- Hits         8708     8706       -2     
  Misses       2052     2052              
Flag Coverage Δ
unit_tests 80.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/visualization/precipfields.py 82.70% <100.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10540d2...7fe6e2a. Read the comment docs.

@dnerini dnerini merged commit 6752bad into master Jan 27, 2022
@dnerini dnerini deleted the fix-colorbar-title branch January 27, 2022 07:40
@dnerini dnerini added this to the v1.6 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant