Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml, remove requirements.txt #204

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

sneakers-the-rat
Copy link
Contributor

keeping consistent with the content of our guides, removed the requirements.txt and switched to using pyproject.toml. They had already gotten out of sync, and so one lil tiny tweak to hopefully make things a lil smoother.

Set it to use dynamic versioning bc that's what i saw u using over here pyOpenSci/pyosMeta#85

and bypassed package check since this isn't a package per se.

dependencies are made not optional since it's not clear what one would be doing installing this empty package without the deps lol <3

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup @sneakers-the-rat

@willingc willingc merged commit fc0b7d6 into pyOpenSci:main Mar 20, 2024
4 checks passed
@sneakers-the-rat
Copy link
Contributor Author

Ah but I did not merge main here after the docs test PR was merged, so that will fail after removing requirements.txt, hang on and ill make another :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants