Skip to content

Improve pythonic naming in function and minor edits #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2024
Merged

Improve pythonic naming in function and minor edits #35

merged 3 commits into from
Oct 21, 2024

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Oct 21, 2024 •
edited
Loading

This PR updates the "Intro to clean code lesson":

  • adds newline after imports in examples
  • add a logical separation ("Another example") between two sets of examples
  • make the names for temperature example more explicit
  • correct code example

lwasser
lwasser approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @willingc merging this!

@lwasser lwasser merged commit e1bd3bf into pyOpenSci:main Oct 21, 2024
4 checks passed
@willingc willingc deleted the clean-lesson branch October 23, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwasser lwasser lwasser approved these changes

@sneakers-the-rat sneakers-the-rat Awaiting requested review from sneakers-the-rat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willingc @lwasser