-
Notifications
You must be signed in to change notification settings - Fork 12
General lattice builder #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This draft PR contains a scaffold that @1234somesh can build upon to create the final feature. Among other things, we need to add support for pyMBE types and residues, tesselated lattices in non-cubic boxes, particle and bond insertion in ESPResSo systems. The lattice builder works in lattice units, i.e. the diamond unit cells goes from (0, 0, 0) to (4, 4, 4), and nodes are labeled using square brackets. Be sure to double-check consistency of this notation with the one used in material sciences (e.g. the Miller index), or opt for a different notation. Open-ended questions:
|
|
@jngrad thank you for an impresive and fast work to provide a template for the pyMBE builder of hydrogel networks! The structure looks pretty good to me and I think that is sensible to have this feature as a separate library, at least while we are developing it. Maybe a couple of suggestions for @1234somesh:
|
|
I have few questions how to proceed with the task. The goal of the task is to use I was thinking that, we can modify The question basically is, how do I use |
|
Notes from on-person discussion with @pm-blanco: We need to split the logic in my current hydrogel.py script into two:
|
pm-blanco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Description of changes: