Update changelog and switch from os.makedirs to Path().mkdir() #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last periodic
samplesjob failed with the following error:When I re-ran the
samplesjob manually on Github it passed and all tests passed locally on my desk computer as well. I suspect that the issue was in the following lines:which can result on an error when executing a script with multiple threats if it happens that two (or more) processes execute the first line before the first threat creates a folder in the following one. To avoid this issue I have decided to switch to pathlib instead:
I believe that this should solve the issue, although I was not able to reproduce the initial error. I took the chance also to update our changelog.