bugfix: support backbone_vector as a list
#120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinedaps
reviewed
Mar 28, 2025
Contributor
pinedaps
left a comment
pinedaps
left a comment
There was a problem hiding this comment.
Looks OK. Nevertheless, It seems a bit more straightforward to me to put it as the else option of the already existing "if backbone_vector is None:" in the line 908 in
the case of pmb.create_molecule() and in the existing else for pmb.create_residue() in line 1193.
1234somesh
pushed a commit
to 1234somesh/pyMBE
that referenced
this pull request
May 21, 2025
* bugfix: support backbone_vector as a list * remove unnecesary code lines, move missplaced if condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to solve a bug reported by @nejedlama.
Fixed
backbone_vectoras list instead than andarrayinpmb.create_molecule()