Improve CI testing and pyMBE log #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 11, 2025 19:23
… unit for pymbe_library.get_radius_map()
…ke more robust. Remove unnecessary pieces of code in pyMBE (assign_molecule and get_type_map)
pm-blanco
changed the title
…emove verbose optional arguments
pm-blanco
previously approved these changes
Mar 13, 2025
pm-blanco
approved these changes
Mar 13, 2025
1234somesh
pushed a commit
to 1234somesh/pyMBE
that referenced
this pull request
May 21, 2025
* Improve coverage of pymbe_library.get_particle_id_map() and make test unit for pymbe_library.get_radius_map() * Modification of the test for get_particle_id and get_radius_map to make more robust. Remove unnecessary pieces of code in pyMBE (assign_molecule and get_type_map) * Solving issues with unusued variable: used_molecules_id * Added two unit test for the print statements in add_value_to_df() * modernize unit test for io_df, start implementing loggins in pyMBE, remove verbose optional arguments * fix test and tutorial * clean up kernel in the tutorial --------- Co-authored-by: blancoapa <pablb@ntnu.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix to #58 and #115
Added
pmb.get_particle_id_map,pmb.get_radius_map,pmb.assign_molecule_idFixed
get_type_mappmb.delete_entry_from_dfRemoved
verboseoptional argument has been deprecated in most of pyMBE methods. Now the modulelogginsis used instead for handling pyMBE's logs.