add rfftfreq to the numpy interfaces #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfftfreq was introduced in numpy 1.8
|
ping. This one should be an easy review |
hgomersall
approved these changes
Feb 9, 2018
|
Sorry, yes. Please merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #206,
rfftfreqis missing from ournumpyinterfaces. This PR adds it (just a re-export of numpy's function).rfftfreqappears to have been introduced innumpy1.8. I have made the code here compatible with oldernumpyas well, but if we are indeed bumping our minimum supported version to 1.10 as proposed in #204 the error/version checking is not strictly necessary.closes #206