Diffraction module updates #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling dev
Updating dependencies
Adding cluster class, plus some additional changes from diffraction and phase_contrast branches
smribet
approved these changes
Jun 12, 2025
Collaborator
smribet
left a comment
smribet
left a comment
There was a problem hiding this comment.
Great, PR! Thanks! I am excited about the clustering @serinlee1065 @cophus
Contributor
|
Yah hooray! Thank you for approving it!
Best,
Serin
…________________________________
From: Stephanie Ribet ***@***.***>
Sent: Wednesday, June 11, 2025 5:30 PM
To: py4dstem/py4DSTEM ***@***.***>
Cc: Serin Lee ***@***.***>; Mention ***@***.***>
Subject: Re: [py4dstem/py4DSTEM] Diffraction module updates (PR #725)
@smribet approved this pull request.
Great, PR! Thanks! I am excited about the clustering @serinlee1065<https://github.com/serinlee1065> @cophus<https://github.com/cophus>
—
Reply to this email directly, view it on GitHub<#725 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APA5BEHBL4VYDV2XSPEBROD3DDC25AVCNFSM6AAAAAB7AEYPQ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMJZGAZTGMBUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some additions from the recent cluster PR