New year, new arina data #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvarnavi
approved these changes
Jan 17, 2025
Member
gvarnavi
left a comment
gvarnavi
left a comment
There was a problem hiding this comment.
lgtm, added two minor comments but will go ahead and approve regardless.
| ) | ||
|
|
||
| try: | ||
| with h5py.File(f"{filename[:-10]}.h5", "r") as f: |
Member
There was a problem hiding this comment.
let's add a comment here to make sure we don't forget that [:-10] comes from dropping the "_master" suffix?
| mem="RAM", | ||
| binfactor: int = 1, | ||
| dtype_bin: float = None, | ||
| fix_transpose=False, |
Member
There was a problem hiding this comment.
It would be great if this default could None, and we could (reliably) detect whether the file is using the old/new ARINA format and set a default value accordingly if not passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small updates to the Arina reader:
Example here.