Skip to content

[MAINT] Improve some tests and refactor dev experience to be in line w/ dowhy #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

adam2392
Copy link
Collaborator

Changes proposed in this pull request:

  • Add a unit test to make sure tuple nodes work as expected
  • Change apply_format to format, which is the same in dowhy

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #74 (dc72551) into main (c387f8a) will increase coverage by 0.38%.
The diff coverage is 71.49%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   84.03%   84.42%   +0.38%     
==========================================
  Files          29       34       +5     
  Lines        2255     2555     +300     
  Branches      578      687     +109     
==========================================
+ Hits         1895     2157     +262     
+ Misses        254      251       -3     
- Partials      106      147      +41     
Impacted Files Coverage Δ
pywhy_graphs/classes/admg.py 95.12% <ø> (ø)
pywhy_graphs/classes/cpdag.py 83.67% <ø> (ø)
pywhy_graphs/classes/pag.py 82.25% <ø> (ø)
pywhy_graphs/export/tigramite.py 0.00% <0.00%> (ø)
pywhy_graphs/testing.py 50.00% <50.00%> (ø)
pywhy_graphs/export/pcalg.py 55.04% <55.04%> (ø)
pywhy_graphs/export/tetrad.py 68.75% <68.75%> (ø)
pywhy_graphs/classes/intervention.py 88.17% <71.42%> (-3.72%) ⬇️
pywhy_graphs/export/numpy.py 72.85% <72.85%> (ø)
pywhy_graphs/export/causallearn.py 79.22% <80.95%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adam2392 adam2392 merged commit 8658c5b into py-why:main Apr 27, 2023
@adam2392 adam2392 deleted the tests branch April 27, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants