version_test: Don't assert that SDL_GetRevision() starts with http #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default format is going to change in 2.25.x, and in git main it currently starts with "SDL-". SDL specifically documents the result of this function as "not intended to be reliable in any way", so it seems wrong to have pysdl2's tests fail whenever the format changes. To address that, turn unexpected formats into an xfail, so that they're flagged as something to investigate but do not make the unit tests fail when used as a QA gate. Closes: py-sdl#248 Signed-off-by: Simon McVittie <smcv@collabora.com>
|
Good catch, thanks as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default format is going to change in 2.25.x, and in git main it currently starts with "SDL-".
SDL specifically documents the result of this function as "not intended to be reliable in any way", so it seems wrong to have pysdl2's tests fail whenever the format changes. To address that, turn unexpected formats into an xfail, so that they're flagged as something to investigate but do not make the unit tests fail when used as a QA gate.
Closes: #248
Merge Checklist
closes #<issue-number>to automatically close an issue