Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROB : utf-16-be' codec can't decode (...) #988 #995

Merged
merged 6 commits into from
Jun 15, 2022
Merged

ROB : utf-16-be' codec can't decode (...) #988 #995

merged 6 commits into from
Jun 15, 2022

Conversation

pubpub-zz
Copy link
Collaborator

No description provided.

@pubpub-zz pubpub-zz mentioned this pull request Jun 14, 2022
Closed
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #995 (947feff) into main (e292822) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
+ Coverage   85.51%   85.55%   +0.03%     
==========================================
  Files          18       18              
  Lines        4178     4180       +2     
  Branches      886      886              
==========================================
+ Hits         3573     3576       +3     
+ Misses        420      419       -1     
  Partials      185      185
Impacted Files Coverage Δ
PyPDF2/_cmap.py 76.87% <ø> (+0.44%) ⬆️
PyPDF2/_page.py 82.77% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e292822...947feff. Read the comment docs.

@MartinThoma
Copy link
Member

My test looks good 👍

May I merge it? It closes #988

@MasterOdin
Copy link
Member

MasterOdin commented Jun 15, 2022 •
edited
Loading

Could one of the PDFs linked in #988 be included as part of an extract_text test so that we have a way to prevent regressions around this?

@MartinThoma
Copy link
Member

@MasterOdin sadly not. We don't know how the copyright situation is. I think downloading it on execution temporarily is OK, but including it in the git history most likely is not. I'm also not happy about it

@pubpub-zz
Copy link
Collaborator Author

My test looks good 👍

May I merge it? It closes #988

All good for me.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
a commit just in time to make @MasterOdin please 😊
cf https://clay-atlas.com/us/blog/2021/09/26/python-en-urllib-error-ssl-certificate/

@MartinThoma MartinThoma merged commit 034d7a9 into py-pdf:main Jun 15, 2022
MartinThoma added a commit that referenced this pull request Jun 17, 2022
@MartinThoma
REL: 2.2.1
91b3e8a 
Performance Improvements (PI):
-  Remove b_ calls (#992, #986)
-  Apply improvements to _utils suggested by perflint (#993)

Robustness (ROB):
-  utf-16-be\' codec can\'t decode (...) (#995)

Documentation (DOC):
-  Remove reference to Scripts (#987)

Developer Experience (DEV):
-  Fix type annotations for add_bookmarks (#1000)

Testing (TST):
-  Add test for PdfMerger (#1001)
-  Add tests for XMP information (#996)
-  reader.get_fields / zlib issue / LZW decode issue (#1004)
-  reader.get_fields with report generation (#1002)
-  Improve test coverage by extracting texts (#998)

Code Style (STY):
-  Apply fixes suggested by pylint (#999)

Full Changelog: 2.2.0...2.2.1
@pubpub-zz pubpub-zz deleted the ExtractText branch August 8, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pubpub-zz @MartinThoma @MasterOdin