ROB: ignore faulty trailing newline during RLE decoding #3355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found PDFs from Dalim software with multi-encoded streams: inner stream is RLE, outer stream is FLATE. The inner stream contains a trailing newline char that breaks the RLE decoding. It seems that there was in some Dalim version a systematíc error that included the bytes of the inner stream just from raw PDF bytes with the trailing newline before "endsrteam". This is fixed with the changes by ignoring the trailing newline and raising a warning instead of an exception.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3355 +/- ##
==========================================
+ Coverage 96.76% 96.83% +0.07%
==========================================
Files 54 54
Lines 9076 9094 +18
Branches 1676 1677 +1
==========================================
+ Hits 8782 8806 +24
+ Misses 176 172 -4
+ Partials 118 116 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Again - was a pleasure and I appreciate to get a more robust PDF tool ;-) |
stefan6419846
added a commit
that referenced
this pull request
Jul 13, 2025
## What's new ### New Features (ENH) - Implement flattening for writer (#3312) by @PJBrs ### Bug Fixes (BUG) - Unterminated object when using PdfWriter with incremental=True (#3345) by @m32 ### Robustness (ROB) - Resolve some image extraction edge cases (#3371) by @stefan6419846 - Ignore faulty trailing newline during RLE decoding (#3355) by @henningkoertelgmg - Gracefully handle odd-length strings in parse_bfchar (#3348) by @stefan6419846 ### Developer Experience (DEV) - Modernize license specifiers (#3338) by @stefan6419846 ### Maintenance (MAINT) - Reduce max-complexity of tool.ruff.lint.mccabe (#3365) by @j-t-1 - Refactor text extraction code by @MartinThoma [Full Changelog](5.7.0...5.8.0)
larsga
pushed a commit
to larsga/pypdf
that referenced
this pull request
Jul 21, 2025
Found PDFs from Dalim software with multi-encoded streams: inner stream is RLE, outer stream is FLATE. The inner stream contains a trailing newline char that breaks the RLE decoding. It seems that there was in some Dalim version a systematíc error that included the bytes of the inner stream just from raw PDF bytes with the trailing newline before "endstream". This is fixed with the changes by ignoring the trailing newline and raising a warning instead of an exception.
larsga
pushed a commit
to larsga/pypdf
that referenced
this pull request
Jul 21, 2025
## What's new ### New Features (ENH) - Implement flattening for writer (py-pdf#3312) by @PJBrs ### Bug Fixes (BUG) - Unterminated object when using PdfWriter with incremental=True (py-pdf#3345) by @m32 ### Robustness (ROB) - Resolve some image extraction edge cases (py-pdf#3371) by @stefan6419846 - Ignore faulty trailing newline during RLE decoding (py-pdf#3355) by @henningkoertelgmg - Gracefully handle odd-length strings in parse_bfchar (py-pdf#3348) by @stefan6419846 ### Developer Experience (DEV) - Modernize license specifiers (py-pdf#3338) by @stefan6419846 ### Maintenance (MAINT) - Reduce max-complexity of tool.ruff.lint.mccabe (py-pdf#3365) by @j-t-1 - Refactor text extraction code by @MartinThoma [Full Changelog](py-pdf/pypdf@5.7.0...5.8.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found PDFs from Dalim software with multi-encoded streams: inner stream is RLE, outer stream is FLATE. The inner stream contains a trailing newline char that breaks the RLE decoding. It seems that there was in some Dalim versions a systematic error that included the bytes of the inner stream just from raw PDF bytes with the trailing newline before "endstream". This is fixed with the changes by ignoring the trailing newline and raising a warning instead of an exception.