BUG: Handle annotations being None on merging #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 52 52
Lines 8811 8813 +2
Branches 1614 1615 +1
=======================================
+ Hits 8501 8503 +2
Misses 185 185
Partials 125 125 ☔ View full report in Codecov by Sentry. |
stefan6419846
added a commit
that referenced
this pull request
Feb 9, 2025
## What's new ### New Features (ENH) - Handle attachments in /Kids and provide object-oriented API (#3108) by @stefan6419846 ### Bug Fixes (BUG) - Handle annotations being None on merging (#3111) by @stefan6419846 ### Robustness (ROB) - Prevent excessive layout mode text output from Type3 fonts (#3082) by @shartzog ### Documentation (DOC) - stefan6419846 becomes BDFL of pypdf (#3078) by @MartinThoma ### Developer Experience (DEV) - Remove ignoring multiple Ruff rules by @j-t-1 - Remove unused mutmut configuration (#3092) by @stefan6419846 ### Testing (TST) - Fix warning assertions to use `pytest.warns()` (#3083) by @mgorny [Full Changelog](5.2.0...5.3.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3110.