STY: Rename b_ to bytes_ #2791
Closed
STY: Rename b_ to bytes_ #2791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More self-documenting and consistent with str_.
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 51 51
Lines 8545 8545
Branches 1703 1703
=======================================
Hits 8132 8132
Misses 261 261
Partials 152 152 ☔ View full report in Codecov by Sentry. |
tests/test_utils.py
Outdated
| ("😀😃", "😀😃".encode()), | ||
| ], | ||
| ) | ||
| def test_b(input_str: str, expected: bytes): |
Collaborator
There was a problem hiding this comment.
We should update the test name as well.
Collaborator
|
please standby on b_ : I would like first to finish my analysis. This may introduce some slight performance improvements |
More self-documenting and consistent with str_.
pubpub-zz
added a commit
to pubpub-zz/pypdf
that referenced
this pull request
Aug 8, 2024
closes py-pdf#2726 superseed proposal py-pdf#2791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More self-documenting and consistent with str_.