PI: Re-use content stream #2101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
- Coverage 94.16% 94.13% -0.03%
==========================================
Files 41 41
Lines 7385 7387 +2
Branches 1459 1460 +1
==========================================
Hits 6954 6954
- Misses 268 269 +1
- Partials 163 164 +1
☔ View full report in Codecov by Sentry. |
|
@pubpub-zz This brings a slight performance improvement. Do you think it's a save change or is this problematic? |
|
this change sound good to me but I'm more reserved about #2086. |
MartinThoma
added a commit
that referenced
this pull request
Aug 20, 2023
## What's new ### Security (SEC) - Avoid endless recursion of reading damaged PDF file (#2093) ### Performance Improvements (PI) - Re-use content stream (#2101) ### Maintenance (MAINT) - Make ParseError inherit from PyPdfError (#2097) [Full Changelog](3.15.1...3.15.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #2086