ENH: Extend images interface by returning an ImageFile(File) class #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of colors were not taken into account to process PNG Images also properly process mask to transparency closes py-pdf#1787
checks the rendering
|
I've reported the merge and select what I wanted. the history is not so good I will also isolate a new PR for Inline Image and also Image replacement (to reduce file size specially) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1848 +/- ##
==========================================
- Coverage 93.77% 93.73% -0.05%
==========================================
Files 34 34
Lines 6720 6795 +75
Branches 1320 1338 +18
==========================================
+ Hits 6302 6369 +67
- Misses 272 279 +7
- Partials 146 147 +1
☔ View full report in Codecov by Sentry. |
|
@MartinThoma |
MartinThoma
reviewed
Jun 12, 2023
pypdf/_utils.py
Outdated
|
|
||
|
|
||
| @dataclass | ||
| class FileImage(File): |
There was a problem hiding this comment.
Could you please rename it to ImageFile?
MartinThoma
added
the
soon
MartinThoma
changed the title
MartinThoma
changed the title
MartinThoma
added a commit
that referenced
this pull request
Jun 18, 2023
New Features (ENH): - Extraction of inline images (#1850) - Add capability to replace image (#1849) - Extend images interface by returning an ImageFile(File) class (#1848) - Add set_data to EncodedStreamObject (#1854) Bug Fixes (BUG): - Fix RGB FlateEncode Images(PNG) and transparency (#1834) - Generate static appearance for fields (#1864) [Full Changelog](3.9.1...3.10.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the current image with new attributes (image/indirect_reference).
Allows extension for Inline Images, and image replacement
For the Reviewer