SEC: Use secrets instead of random #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
=======================================
Coverage 92.40% 92.41%
=======================================
Files 34 34
Lines 6570 6575 +5
Branches 1301 1301
=======================================
+ Hits 6071 6076 +5
Misses 326 326
Partials 173 173
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MartinThoma
added a commit
that referenced
this pull request
Mar 26, 2023
Security (SEC): - Use Python's secrets module instead of random module (#1748) New Features (ENH): - Add AnnotationBuilder.highlight text markup annotation (#1740) - Add AnnotationBuilder.popup (#1665) - Add AnnotationBuilder.polyline annotation support (#1726) - Add clone_from parameter in PdfWriter constructor (#1703) Bug Fixes (BUG): - 'DictionaryObject' object has no attribute 'indirect_reference' (#1729) Robustness (ROB): - Handle params NullObject in decode_stream_data (#1738) Documentation (DOC): - Project scope (#1743) Maintenance (MAINT): - Add AnnotationFlag (#1746) - Add LazyDict.__str__ (#1727) [Full Changelog](3.6.0...3.7.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implication of this is that PDFs which were encrypted with pypdf before might be less secure than they should be.
It's unclear to me if "less secure" means "insecure" or if it's just a theoretical advantage.