Prevent deduplication of PageObject #1105
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1105 +/- ##
=======================================
Coverage 91.94% 91.95%
=======================================
Files 24 24
Lines 4642 4646 +4
Branches 957 957
=======================================
+ Hits 4268 4272 +4
Misses 229 229
Partials 145 145
Continue to review full report at Codecov.
|
|
Does this change fix #1102 ? |
|
I haven't yet confirmed that. |
|
I can now confirm this. Seem to be bug in Adobe Acrobat Reader or something like that. I tested this and confirmed that PDF doesn't shown properly Acrobat Reader DC, 2015 Release, Version 2015.007.20033. This changes fixes #1102. Can you find anything from PDF definition document regarding this page object usage multiple times. |
MartinThoma
added
the
soon
|
I'm pretty busy today, but I plan to merge + release this pr this weekend. Thank you already for it ❤️ |
New Features (ENH): - Add color and font_format to PdfReader.outlines[i] (#1104) - Extract Text Enhancement (whitespaces) (#1084) Bug Fixes (BUG): - Use `build_destination` for named destination outlines (#1128) - Avoid a crash when a ToUnicode CMap has an empty dstString in beginbfchar (#1118) - Prevent deduplication of PageObject (#1105) - None-check in DictionaryObject.read_from_stream (#1113) - Avoid IndexError in _cmap.parse_to_unicode (#1110) Documentation (DOC): - Explanation for git submodule - Watermark and stamp (#1095) Maintenance (MAINT): - Text extraction improvements (#1126) - Destination.color returns ArrayObject instead of tuple as fallback (#1119) - Use add_bookmark_destination in add_bookmark (#1100) - Use add_bookmark_destination in add_bookmark_dict (#1099) Testing (TST): - Remove xfail from test_outline_title_issue_1121 - Add test for arab text (#1127) - Add xfail for decryption fail (#1125) - Add xfail test for IndexError when extracting text (#1124) - Add MCVE showing outline title issue (#1123) Code Style (STY): - Apply black and isort - Use IntFlag for permissions_flag / update_page_form_field_values (#1094) - Simplify code (#1101) Full Changelog: 2.5.0...2.6.0
In issue #1102 adobe reader/acrobat doesn't like if same page is referred more than one time