Skip to content

Commit

Permalink
Don't attempt reading from play state (will crash)
Browse files Browse the repository at this point in the history
  • Loading branch information
ItsDrike committed Oct 9, 2023
1 parent f503bc5 commit ae08e99
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ async def main():
client = Client(
host="localhost",
port=25565,
client=client,
httpx_client=client,
account=account,
conn=connection,
protocol_version=763, # 1.20.1
Expand Down
3 changes: 1 addition & 2 deletions mcproto/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,5 +222,4 @@ async def login(self) -> None:
# Wait for Login (play) packet now. It could take a while for some servers to
# transition to the play state, but we can be certain the server won't send any
# other packets before this Login one.
recv_packet = await self._read_packet()
# TODO: Mcproto doesn't yet contain PLAY game state packets
raise NotImplementedError("Play state packets aren't implemented yet")

0 comments on commit ae08e99

Please sign in to comment.