New font ansi-shadow #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ansi-shadow font
pwaller
requested changes
Dec 6, 2020
|
|
||
| https://web.archive.org/web/20120819044459/http://www.roysac.com/thedrawfonts-tdf.asp | ||
|
|
||
| FIGFont created with: http://patorjk.com/figfont-editor |
There was a problem hiding this comment.
What's the license story behind this font? Where did it come from, and what is its license? See also #59. I'm reluctant to accept a PR which is not clear on this front.
There was a problem hiding this comment.
Yeah - based on the analysis we've just gone through, this would be another "contrib" font at best. Possibly a better way to handle these sorts of requests is to add URLs to common locations for font definitions (rather than the fonts themselves)?
Merged
|
I'm going to close this one because I can't work out the licensing implications. Help wanted, if you want to contribute a font please ensure the provenance and license is clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ansi-shadow font.
source: xero/figlet-fonts