Fix output when fluid2d runs on multiple cores #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fluid2d runs on multiple cores, the name of the his file displayed at the end was wrong. The filename that was printed after the simulation finished was the name of one of the his-files which was joined into one big his-file and then removed. With this commit, fluid2d prints the correct name of the his-file after the run even when using multiple cores. The same is true for the flux file. Creating an mp4-file while fluid2d runs on multiple cores was possible so far, however, it resulted in the creation of just one file which shows only some part of the domain, not fully. Therefore it was only limited usefully. Furthermore it led to a crash, since several fluid2d-processes called "finalize" on the same file. Also creating an mp4-file, which is not really helpful wastes resouces. Therefore, this commit disables the possbility to generate mp4s when fluid2d runs on multiple cores. A warning is printed instead. The member variables of Output hisfile_joined and flxfile_joined were unused and are now removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fluid2d runs on multiple cores, the name of the his file displayed
at the end was wrong. The filename that was printed after the
simulation finished was the name of one of the his-files which was
joined into one big his-file and then removed. With this commit,
fluid2d prints the correct name of the his-file after the run even when
using multiple cores. The same is true for the flux file.
Creating an mp4-file while fluid2d runs on multiple cores was possible
so far, however, it resulted in the creation of just one file which
shows only some part of the domain, not fully. Therefore it was only
limited usefully. Furthermore it led to a crash, since several
fluid2d-processes called "finalize" on the same file. Also creating an
mp4-file, which is not really helpful wastes resouces. Therefore, this
commit disables the possbility to generate mp4s when fluid2d runs on
multiple cores. A warning is printed instead.
The member variables of Output hisfile_joined and flxfile_joined were
unused and are now removed.