Fix path handling issues in MkDocs generation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsnx222
commented
Feb 26, 2025
rsnx222
commented
- gen_pages.py: Ensured source_dir is always an absolute Path to prevent NoneType errors.
- name_conversion.py: Fixed an issue where channel['path'] could be None, ensuring valid path operations.
- rules.py: Prevented NoneType errors when formatting Discord channel links by defaulting to a safe path.
- page_generator.py: Fixed relative_to() path errors by resolving absolute paths and falling back if paths don’t match.
gen_pages.py: Ensured source_dir is always an absolute Path to prevent NoneType errors. name_conversion.py: Fixed an issue where channel['path'] could be None, ensuring valid path operations. rules.py: Prevented NoneType errors when formatting Discord channel links by defaulting to a safe path. page_generator.py: Fixed relative_to() path errors by resolving absolute paths and falling back if paths don’t match.
Still needs "first child" logic when you click on category
renamed section to "boss guides" to avoid confusion with pvme-guides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.