Update PVGIS docs and test to comply with PVGIS version 5.2#1502
Merged
AdamRJensen merged 5 commits intopvlib:masterfrom Aug 15, 2022
Merged
Update PVGIS docs and test to comply with PVGIS version 5.2#1502AdamRJensen merged 5 commits intopvlib:masterfrom
AdamRJensen merged 5 commits intopvlib:masterfrom
Conversation
Member
Author
|
There's hardly anything to add to the whatsnew as the functionality has not changed. If anyone thinks that it would be meaningful I'll be happy to add an entry though. |
kandersolar
reviewed
Jul 24, 2022
kandersolar
approved these changes
Jul 26, 2022
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
LGTM, thanks @AdamRJensen!
AdamRJensen
added
remote-data
Member
Author
|
@pvlib/pvlib-maintainer feel free to leave a second review, otherwise, I'll go ahead and merge this PR on August 12th. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR removes references to the retired PVGIS irradiance databases CMSAF and COSMO. The CMSAF test file has been replaced with a SARAH2 test file. Additionally, minor doc updates were made, e.g.,
PVGIS_VARIABLE_MAPwas renamed toVARIABLE_MAP.