Consider altitude in `pvlib.solarposition.sun_rise_set_transit_spa`

[carlosg-m]

Why are the parameters in pvlib.solarposition.spa_python no the same as pvlib.solarposition.sun_rise_set_transit_spa?

Parameters altitude, pressure, temperature and others are missing.

[cwhanse]

For calculating sunrise and sunset, the SPA algorithm (reference [1], Reda et al. 2003) sets the atmospheric refraction to a fixed angle at the horizon. For this reason, the calculation doesn't the atmospheric parameters.

Please note, questions are usually better raised in the Discussion tab.