Skip to content

ModelChain.pvwatts_losses creates self.losses instead of ModelChainResult.losses #1184

Closed
@wholmgren

Description

@wholmgren

@ncroft-b4 reports...

It looks like pvwatts_losses still creates a self.losses attribute.

Thanks for catching that. pvwatts_losses and no_extra_losses should assign values to ModelChainResults, and ModelChain._deprecated_attrs should include losses. We can address that in another issue/pr.

Originally posted by @wholmgren in #1168 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions