Add support for **kwargs
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipturner
changed the title
**kwargs
|
Are the changes to line indentation acceptable, or should I revert them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another spawn of Swift-Colab. I modified the internal representation of
PyFunctionto store an opaque function pointer that casts to two different types. There is also a new method onPythonObjectandThrowingPythonObject, but that does not interfere with the existingdynamicCallablefunctionality. Furthermore, I future-proofed PythonKit against any solutions to SR-15871.I did make some minor modifications to code style. One was ensuring the first line in a function was indented once. Previously, it could be indented twice if there was a
whereclause. Also, I changedparamstoargsin closures for declaration ofPythonFunction.