Skip to content

Commit 5bd8e73

Browse files
authored
Merge pull request #4 from pvelx/develop
renamed adapter of trigger service
2 parents 1cc4006 + 22fdd43 commit 5bd8e73

File tree

13 files changed

+57
-57
lines changed

13 files changed

+57
-57
lines changed

config/packages/messenger.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ framework:
2020
# sync: 'sync://'
2121

2222
routing:
23-
'App\Service\TaskServerGrpcAdapter\BusMessage\TaskExecuteMessage': async
23+
'App\Service\TriggerServiceGrpcAdapter\BusMessage\TriggerExecutedMessage': async

config/services.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,23 +30,23 @@ services:
3030
# add more service definitions when explicit configuration is needed
3131
# please note that last definitions always *replace* previous ones
3232

33-
App\Service\TaskServerGrpcAdapter\TaskServerGrpcAdapter:
33+
App\Service\TriggerServiceGrpcAdapter\TriggerServiceGrpcAdapter:
3434
arguments:
3535
$host: '%env(TASK_GRPC_SERVER_HOST)%'
3636

37-
App\Contract\TaskServerAdapter\TaskServerAdapterInterface:
38-
alias: App\Service\TaskServerGrpcAdapter\TaskServerGrpcAdapter
37+
App\Contract\TriggerServiceAdapter\TriggerServiceAdapterInterface:
38+
alias: App\Service\TriggerServiceGrpcAdapter\TriggerServiceGrpcAdapter
3939

4040
task_server_grpc_adapter.serializer:
4141
class: App\Serializer\AmqpMessageSerializer
4242
arguments:
43-
$messageClass: App\Service\TaskServerGrpcAdapter\BusMessage\TaskExecuteMessage
43+
$messageClass: App\Service\TriggerServiceGrpcAdapter\BusMessage\TriggerExecutedMessage
4444

4545
App\Service\TaskService\TaskService:
4646
tags:
4747
- name: kernel.event_listener
48-
event: App\Service\TaskServerGrpcAdapter\Event\TaskExecuteEvent
49-
method: onTaskExecuteEvent
48+
event: App\Service\TriggerServiceGrpcAdapter\Event\TriggerExecutedEvent
49+
method: onTriggerExecutedEvent
5050

5151
App\Domain\Message\MessageManager:
5252
tags:

src/Contract/TaskServerAdapter/TaskServerAdapterExceptionInterface.php

Lines changed: 0 additions & 9 deletions
This file was deleted.
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php declare(strict_types=1);
2+
3+
4+
namespace App\Contract\TriggerServiceAdapter;
5+
6+
interface TriggerServiceAdapterExceptionInterface extends \Throwable
7+
{
8+
9+
}
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
<?php declare(strict_types=1);
22

33

4-
namespace App\Contract\TaskServerAdapter;
4+
namespace App\Contract\TriggerServiceAdapter;
55

66
use Proto\Request;
77
use Proto\Response;
88

9-
interface TaskServerAdapterInterface
9+
interface TriggerServiceAdapterInterface
1010
{
1111
/**
1212
* @param Request $request
1313
* @return Response
14-
* @throws TaskServerAdapterExceptionInterface
14+
* @throws TriggerServiceAdapterExceptionInterface
1515
*/
1616
public function create(Request $request): Response;
1717

1818
/**
1919
* @param Request $request
2020
* @return Response
21-
* @throws TaskServerAdapterExceptionInterface
21+
* @throws TriggerServiceAdapterExceptionInterface
2222
*/
2323
public function delete(Request $request): Response;
2424
}

src/Service/MailerMockService/MailerMockService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ class MailerMockService implements MailerInterface
1616
*/
1717
public function send(string $recipient, string $text)
1818
{
19-
19+
//TODO make me
2020
}
2121
}

src/Service/TaskServerGrpcAdapter/Exception/TaskServerGrpcAdapterException.php

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/Service/TaskService/TaskService.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33

44
namespace App\Service\TaskService;
55

6-
use App\Contract\TaskServerAdapter\TaskServerAdapterInterface;
6+
use App\Contract\TriggerServiceAdapter\TriggerServiceAdapterInterface;
77
use App\Contract\TaskService\TaskServiceInterface;
88
use App\Service\TaskService\Entity\Task;
99
use App\Service\TaskService\Event\TaskCanceledEvent;
1010
use App\Service\TaskService\Event\TaskCreatedEvent;
1111
use App\Service\TaskService\Exception\TaskServiceException;
1212
use App\Service\TaskService\Repository\TaskRepository;
13-
use App\Service\TaskServerGrpcAdapter\Event\TaskExecuteEvent;
13+
use App\Service\TriggerServiceGrpcAdapter\Event\TriggerExecutedEvent;
1414
use DateTime;
1515
use Doctrine\ORM\EntityManagerInterface;
1616
use Doctrine\ORM\EntityNotFoundException;
@@ -23,21 +23,21 @@
2323

2424
class TaskService implements TaskServiceInterface
2525
{
26-
private $taskServerAdapter;
26+
private $triggerServiceAdapter;
2727
private $entityManager;
2828
private $eventDispatcher;
2929
private $repository;
3030
private $logger;
3131

3232
public function __construct(
33-
TaskServerAdapterInterface $taskServerAdapter,
33+
TriggerServiceAdapterInterface $triggerServiceAdapter,
3434
EntityManagerInterface $entityManager,
3535
EventDispatcherInterface $eventDispatcher,
3636
TaskRepository $repository,
3737
LoggerInterface $logger
3838
)
3939
{
40-
$this->taskServerAdapter = $taskServerAdapter;
40+
$this->triggerServiceAdapter = $triggerServiceAdapter;
4141
$this->entityManager = $entityManager;
4242
$this->eventDispatcher = $eventDispatcher;
4343
$this->repository = $repository;
@@ -59,7 +59,7 @@ public function create(DateTime $execTime, string $taskType, int $entityId): Tas
5959
$request = new Request();
6060
$request->setExecTime($execTime->getTimestamp());
6161

62-
$response = $this->taskServerAdapter->create($request);
62+
$response = $this->triggerServiceAdapter->create($request);
6363

6464
$task = (new Task())
6565
->setStatus(Task::STATUS_PENDING)
@@ -108,7 +108,7 @@ public function cancel(string $taskType, int $entityId): TaskCanceledEvent
108108
$request = (new Request())
109109
->setId($task->getExternalId());
110110

111-
$response = $this->taskServerAdapter->delete($request);
111+
$response = $this->triggerServiceAdapter->delete($request);
112112
if ($response->getStatus() != 'ok') {
113113
throw new RuntimeException('Deleting in task server was failed');
114114
}
@@ -136,9 +136,9 @@ public function cancel(string $taskType, int $entityId): TaskCanceledEvent
136136
}
137137

138138
/**
139-
* @param TaskExecuteEvent $event
139+
* @param TriggerExecutedEvent $event
140140
*/
141-
public function onTaskExecuteEvent(TaskExecuteEvent $event): void
141+
public function onTriggerExecutedEvent(TriggerExecutedEvent $event): void
142142
{
143143
try {
144144
$task = $this->repository->findOneByExternalId($event->getTaskId());
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<?php declare(strict_types=1);
22

33

4-
namespace App\Service\TaskServerGrpcAdapter;
4+
namespace App\Service\TriggerServiceGrpcAdapter;
55

6-
use App\Service\TaskServerGrpcAdapter\BusMessage\TaskExecuteMessage;
7-
use App\Service\TaskServerGrpcAdapter\Event\TaskExecuteEvent;
6+
use App\Service\TriggerServiceGrpcAdapter\BusMessage\TriggerExecutedMessage;
7+
use App\Service\TriggerServiceGrpcAdapter\Event\TriggerExecutedEvent;
88
use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
99
use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
1010

@@ -17,8 +17,8 @@ public function __construct(EventDispatcherInterface $dispatcher)
1717
$this->dispatcher = $dispatcher;
1818
}
1919

20-
public function __invoke(TaskExecuteMessage $message)
20+
public function __invoke(TriggerExecutedMessage $message)
2121
{
22-
$this->dispatcher->dispatch(new TaskExecuteEvent($message->getTaskId()));
22+
$this->dispatcher->dispatch(new TriggerExecutedEvent($message->getTaskId()));
2323
}
2424
}

src/Service/TaskServerGrpcAdapter/BusMessage/TaskExecuteMessage.php renamed to src/Service/TriggerServiceGrpcAdapter/BusMessage/TriggerExecutedMessage.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<?php declare(strict_types=1);
22

33

4-
namespace App\Service\TaskServerGrpcAdapter\BusMessage;
4+
namespace App\Service\TriggerServiceGrpcAdapter\BusMessage;
55

66

7-
class TaskExecuteMessage
7+
class TriggerExecutedMessage
88
{
99
private $taskId;
1010

0 commit comments

Comments
 (0)