Skip to content

Commit 1cc4006

Browse files
authored
Merge pull request #3 from pvelx/develop
fix bugs
2 parents e3395cb + b61169e commit 1cc4006

File tree

6 files changed

+5
-14
lines changed

6 files changed

+5
-14
lines changed

config/services.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33

44
# Put parameters here that don't need to change on each machine where the app is deployed
55
# https://symfony.com/doc/current/best_practices/configuration.html#application-related-configuration
6-
parameters:
7-
env(RABBITMQ_DSN): 'amqp://rebbitmq:secret@rabbitmq:5672/%2f'
8-
96

107
services:
118
# default configuration for services in *this* file

docker/Dockerfile

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@ RUN apk add --no-cache \
1414
unzip \
1515
zlib-dev \
1616
linux-headers \
17-
rabbitmq-c-dev
18-
19-
20-
# Optional, force UTC as server time
21-
RUN echo "UTC" > /etc/timezone
17+
rabbitmq-c-dev \
18+
supervisor
2219

2320

2421
# Install composer
@@ -54,7 +51,6 @@ RUN pecl install amqp && docker-php-ext-enable amqp
5451
RUN pecl install grpc-1.33.1
5552
RUN docker-php-ext-enable grpc
5653

57-
RUN apk add --no-cache supervisor
5854
RUN rm /etc/supervisord.conf
5955
COPY supervisor/ /etc/supervisor/
6056

src/Domain/Message/Dto/ScheduleSendingMessage.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ScheduleSendingMessage
2323

2424
/**
2525
* @var DateTime
26-
* @JMS\Type("DateTime<'Y-m-d H:i:s'>")
26+
* @JMS\Type("DateTime<'U'>")
2727
*/
2828
private $execTime;
2929

src/Domain/Message/Entity/Message.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class Message
6060

6161
/**
6262
* @ORM\Column(type="datetime")
63+
* @JMS\Type("DateTime<'U'>")
6364
* @JMS\Expose()
6465
*/
6566
private $execTime;

src/Service/TaskService/Config.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class Config
1515
self::TASK_TYPE_SENDING_PUSH => SendingTimeMessageTriggeredEvent::class
1616
];
1717

18-
static public function getEventByType($type): BaseEvent
18+
static public function getEventByType($type): string
1919
{
2020
return self::$bindTaskTypeToEvent[$type];
2121
}

src/Service/TaskService/TaskService.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ public function cancel(string $taskType, int $entityId): TaskCanceledEvent
141141
public function onTaskExecuteEvent(TaskExecuteEvent $event): void
142142
{
143143
try {
144-
$this->entityManager->beginTransaction();
145144
$task = $this->repository->findOneByExternalId($event->getTaskId());
146145

147146
if (null === $task) {
@@ -163,12 +162,10 @@ public function onTaskExecuteEvent(TaskExecuteEvent $event): void
163162
$task->setStatus(Task::STATUS_COMPLETED);
164163
$this->entityManager->persist($task);
165164
$this->entityManager->flush();
166-
$this->entityManager->commit();
167165

168166
$eventClass = Config::getEventByType($task->getTaskType());
169167
$this->eventDispatcher->dispatch(new $eventClass($task->getId(), $task->getEntityId()));
170168
} catch (Throwable $e) {
171-
$this->entityManager->rollback();
172169
$this->logger->error(
173170
'Error while handle the task',
174171
['exception' => $e, 'method' => __METHOD__, 'entityId' => $event->getTaskId()]

0 commit comments

Comments
 (0)