Draft
Conversation
MasterEvarior
force-pushed
the
feature/improve-gh-workflows
branch
2 times, most recently
from
a946eac to
be8c30d
Compare
MasterEvarior
force-pushed
the
feature/improve-gh-workflows
branch
2 times, most recently
from
4580d93 to
cc147e0
Compare
MasterEvarior
force-pushed
the
feature/improve-gh-workflows
branch
from
622d0f2 to
a42a9f1
Compare
Collaborator
|
do we still need this pr? |
kcinay055679
requested changes
Jan 9, 2026
Collaborator
kcinay055679
left a comment
kcinay055679
left a comment
There was a problem hiding this comment.
- potential cache docker image build, just once and then use this image in every e2e test, use same image that got tested by e2e to publish
- dep caching docker use pom.xml as reference to check for change
result of convo with @MasterEvarior
| id: sonarqube-quality-gate-check | ||
| uses: SonarSource/sonarqube-quality-gate-action@v1.2.0 | ||
| with: | ||
| scanMetadataReportFile: target/sonar/report-task.txt |
| with: | ||
| name: backend-test-reports | ||
| path: | | ||
| backend/target/site/ |
Collaborator
There was a problem hiding this comment.
find out which is actaully required and delete the other so we don't waste time for uploading
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.sonarsource.scanner.maven</groupId> | ||
| <artifactId>sonar-maven-plugin</artifactId> | ||
| <version>5.3.0.6276</version> |
Collaborator
There was a problem hiding this comment.
i think this version specification is not needed since we define it in plugin management but to be checked
MasterEvarior
force-pushed
the
feature/improve-gh-workflows
branch
2 times, most recently
from
d00fb0a to
555f102
Compare
|
1 similar comment
|
MasterEvarior
force-pushed
the
feature/improve-gh-workflows
branch
2 times, most recently
from
7164056 to
be93f9d
Compare
MasterEvarior
force-pushed
the
feature/improve-gh-workflows
branch
from
789207e to
71b9838
Compare
# Conflicts: # frontend/package.json
ci: add caching to e2e docker images "revert: add caching to e2e docker images" This reverts commit 73ad341.
MasterEvarior
force-pushed
the
feature/improve-gh-workflows
branch
from
71b9838 to
c62204c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.