Incorrectly decoding data

[Robin481]

We haven't pinned down the reason 100% but it seems that the ccli can come to a point when syncing secrets that it tries to Base64-decode non-Base64 encoded strings.

This method:

def decoded_data(data)
    return {} unless data

    data.transform_values do |value|
      Base64.strict_decode64(value)
    rescue ArgumentError
      value
    end
end

is probably the biggest culprit as normally a non Base64 encoded String will just throw an error and return its value but in my case a non-Base64 encoded string was recognized as Base64, was therefore decoded and broke everything.

I have an example string for this case that I can share when needed.

[nilsrauch]

Kind of confused why we're disecting the whole yml here: https://github.com/puzzle/ccli/blob/8ea35525c9/lib/serializers/ose_secret_serializer.rb#L9
We should just be able to do OSESecret.new(Psych.load(yaml)['metadata']['name'], yaml)
We're saving the whole yml to cryptopus anyways, so digging around in the yml and decoding stuff just seems.. unnecessary.
This would also mean that we don't have to encrypt anything anymore after pulling from cryptopus: https://github.com/puzzle/ccli/blob/8ea35525c9/lib/serializers/ose_secret_serializer.rb#L30
I'm not saying this fixes the issue. But it just feels so weird that I'm hoping that we can either actually identify or by chance kill the bug in the process.