-
Notifications
You must be signed in to change notification settings - Fork 0
L4R routing #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
L4R routing #1
Conversation
| @@ -0,0 +1,408 @@ | |||
| /** @file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a bad idea - this isn't going to be a different proxy server.
| starting to accept on them. | ||
|
|
||
| */ | ||
| struct L4RProxyAcceptor { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go in to "iocore/net" along with the other accept logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, really, you shouldn't need a separate Acceptor at all. For example, if the inbound connection is TLS the determination to L4 proxy it can't be made until after the Client Hello packet has been recieved, which is long after all the accept logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented a L7 interceptor (after the SSL handshake) because I thought we will need this one as well for the case: non secure incoming connection -> outgoing secure connection
I was going to implement the SSL case after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Layer 4 proxying must be able to run on the same ports as other traffic, it can't require dedicate proxy ports or executables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. But I thought for non SSL in, non SSL out case we will have to make the decision based on the port number.
|
I thought you were going to start with looking at a protocol super class for HttpSM. |
|
I didn't get that far to implement HttpSM. |
|
I think it's a better place to start. |
Setting up the intercept in trampoline code so far.