IL2CPP incompatibility.

[D3m0n92]

As soon as the app starts, I get the following error:

NotSupportedException: System.Reflection.Emit.DynamicMethod::.ctor

System.Reflection.Emit.DynamicMethod..ctor (System.String name, System.Type returnType, System.Type[] parameterTypes, System.Type owner, System.Boolean skipVisibility) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.Utilities.DynamicReflectionDelegateFactory.CreateDynamicMethod (System.String name, System.Type returnType, System.Type[] parameterTypes, System.Type owner) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.Utilities.DynamicReflectionDelegateFactory.CreateParameterizedConstructor (System.Reflection.MethodBase method) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.Serialization.DefaultContractResolver.CreateObjectContract (System.Type objectType) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.Serialization.DefaultContractResolver.CreateContract (System.Type objectType) (at <00000000000000000000000000000000>:0)
System.Func2[T,TResult].Invoke (T arg) (at <00000000000000000000000000000000>:0) System.Collections.Concurrent.ConcurrentDictionary2[TKey,TValue].GetOrAdd (TKey key, System.Func2[T,TResult] valueFactory) (at <00000000000000000000000000000000>:0) Newtonsoft.Json.Utilities.ThreadSafeStore2[TKey,TValue].Get (TKey key) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.Serialization.DefaultContractResolver.ResolveContract (System.Type type) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.GetContractSafe (System.Type type) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize (Newtonsoft.Json.JsonReader reader, System.Type objectType, System.Boolean checkAdditionalContent) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.JsonSerializer.DeserializeInternal (Newtonsoft.Json.JsonReader reader, System.Type objectType) (at <00000000000000000000000000000000>:0)
Newtonsoft.Json.JsonSerializer.Deserialize (Newtonsoft.Json.Json

[damdo]

Ciao Vincenzo,
I'm sorry you are running into this issue and thank you for reporting it.
This is an issue caused by the fact that pusher-websocket-dotnet (the parent library that pusher-websocket-unity is using) utilises Newtonsoft.Json which is still incompatible with IL2CPP (here is the PR that could potentially make it compatible JamesNK/Newtonsoft.Json#2044). More about that here: (pusher/pusher-websocket-dotnet#83).

We are considering different options to fix this, and it is for us high priority to do so.
Please bear with us, we will keep you posted.

[twomedia]

Glad to see an official Unity lib for Pusher! We're waiting on IL2CPP support as well before we can move away from our custom implementation. Hopefully we'll see that PR merged soon 🤞🏻

[damdo]

Hey Thomas (@twomedia), thank you.

I've just released a new version of pusher-websocket-unity
here -> https://github.com/pusher/pusher-websocket-unity/releases/tag/1.1.2%2B200211

This version switches to the fork of Newtonsoft.Json with support for IL2CPP that I mentioned in the comment above (https://github.com/jilleJr/Newtonsoft.Json-for-Unity).

It would be great if you could give some feedback on it, and see if it works for you 😬

[twomedia]

@damdo Thanks for jumping on this so quickly! Unfortunately, we haven't had much luck getting it working on device for both our projects today (It works great in Editor though). We seem to be getting the following error spammed in the console when attempting to connect:

Pusher Error: Missing parameter: event
PusherManager:OnPusherOnError(Object, PusherException)
PusherClient.Connection:ParseError(String)
WebSocket4Net.WebSocket:ExecuteCommand(WebSocketCommandInfo)
WebSocket4Net.WebSocket:OnDataReceived(Byte[], Int32, Int32)
SuperSocket.ClientEngine.AuthenticatedStreamTcpSession:OnDataRead(IAsyncResult)
System.Threading.Tasks.AwaitTaskContinuation:InvokeAction(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Threading.Tasks.AwaitTaskContinuation:RunCallback(ContextCallback, Object, Task&)
System.Threading.Tasks.Task:FinishContinuations()
System.Threading.Tasks.Task`1:TrySetResult(TResult)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Create()
Mono.Net.Security.<>c__DisplayClass66_0:<InnerRead>b__0()
System.Runtime.CompilerServices.MoveNextRunner:InvokeMoveNext(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Runtime.CompilerServices.MoveNextRunner:Run()
System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction(Action, Boolean, Task&)
System.Threading.Tasks.Task:FinishContinuations()
System.Threading.Tasks.Task`1:TrySetResult(TResult)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Create()
Mono.Net.Security.MobileAuthenticatedStream:InnerWrite(Boolean, CancellationToken)
System.Runtime.CompilerServices.MoveNextRunner:InvokeMoveNext(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Runtime.CompilerServices.MoveNextRunner:Run()
System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction(Action, Boolean, Task&)
System.Threading.Tasks.Task:FinishContinuations()
System.Threading.Tasks.Task`1:TrySetResult(TResult)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Create()
Mono.Net.Security.MobileAuthenticatedStream:InnerRead(Boolean, Int32, CancellationToken)
System.Runtime.CompilerServices.MoveNextRunner:InvokeMoveNext(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Runtime.CompilerServices.MoveNextRunner:Run()
System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction(Action, Boolean, Task&)
System.Threading.Tasks.Task:FinishContinuations()
System.Threading.Tasks.Task`1:TrySetResult(TResult)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Create()
Mono.Net.Security.AsyncProtocolRequest:ToString()
System.Runtime.CompilerServices.MoveNextRunner:InvokeMoveNext(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Runtime.CompilerServices.MoveNextRunner:Run()
System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction(Action, Boolean, Task&)
System.Threading.Tasks.Task:FinishContinuations()
System.Threading.Tasks.Task`1:TrySetResult(TResult)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Create()
Mono.Net.Security.<>c__DisplayClass66_0:<InnerRead>b__0()
System.Runtime.CompilerServices.MoveNextRunner:InvokeMoveNext(Object)
System.Threading.ExecutionContext:RunInternal(ExecutionContext, ContextCallback, Object, Boolean)
System.Runtime.CompilerServices.MoveNextRunner:Run()
System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction(Action, Boolean, Task&)
System.Threading.Tasks.Task:FinishContinuations()
System.Threading.Tasks.Task`1:TrySetResult(TResult)
System.Threading.Tasks.FromAsyncTrimPromise`1:Complete(TInstance, Func`3, IAsyncResult, Boolean)
System.Net.Sockets.<>c:<Complete>b__27_0(Object)
System.Threading.ThreadPoolWorkQueue:Dispatch()

Ultimately this ends up causing Pusher to switch between Initialized -> Disconnecting -> Disconnected -> WaitingToReconnect states.

In another unrelated issue, when we tried installing the lib using Unity Package Manager we got the following errors:

Not sure if this happens only when using JetBrains Rider IDE (As the stack trace appears to originate from there). We ended up importing using the .unitypackage with no issues.

Sorry for the long post and thanks in advance for the help!

EDIT: I'm gonna look into this further tomorrow to see If I can find any more information.

[twomedia]

Just an update on this issue, we're also seeing the "Pusher Error: Missing parameter: event" error appearing in the Pusher.com error logs page

Besides that, we haven't made much ground on working out the cause.

[CliffCawley]

I was able to fix this error by adding a link.xml with the contents:

<linker>
       <assembly fullname="PusherClient" preserve="all"/>
</linker>

[twomedia]

Just an update on the above. Thanks @CliffCawley, adding to the link.xml file partially fixed the issue for us. We did however have another issue where the app would crash when receiving a channel event. Further investigation found that this was caused by us using the dynamic channel.Bind() method instead of either the string or PusherEvent overloads (As the dynamic keyword is not support by IL2CPP due to its AOT requirements). We seem to be stable now on both of our products and we're entering public testing soon. @damdo It might be worth adding both of the above points to the docs as it definitely will catch others out when using this library.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.