Add support for loading proxy config from the environment #25
Conversation
The popular python deployment platform PythonAnywhere requires that http proxy settings be loaded from the environment when using their free plan (to whitelist domains). This change adds a flag to enable loading this configuration. Fixes #24
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 479 483 +4
=====================================
+ Hits 479 483 +4
Continue to review full report at Codecov.
|
|
|
||
| def _get_proxies_from_env(): | ||
| return { | ||
| 'http': os.environ.get('HTTP_PROXY') or os.environ.get('http_proxy'), |
There was a problem hiding this comment.
It's case sensitive? :o
| # They require that proxy servers be loaded from the environment when | ||
| # making requests (on their free plan). | ||
| # This flag enables this behaviour. | ||
| if self._use_proxy_env_vars: |
There was a problem hiding this comment.
So instead of making a new flag, can't we just have more specific env vars? If we use something like BEAMS_CLIENT_HTTP_PROXY, we don't really need to create this flag because the env var is already specific enough to only apply to this SDK.
If this is a bit awkward as these ones are already set automatically, perhaps we can consider just using them by default? Does urllib3, requests and curl packages require this second flag?
luismfonseca
left a comment
luismfonseca
left a comment
There was a problem hiding this comment.
Looks good.
Don't forget to update the changelog!
The popular python deployment platform PythonAnywhere requires that
http proxy settings be loaded from the environment when using their free plan
(to whitelist domains). This change adds a flag to enable loading this configuration.
Fixes #24