rewrote config handling and a bunch of other stuff #6
Conversation
|
|
||
| func makeRequest(reqtype string, path string, body []byte) (string, error) { | ||
| req, err := http.NewRequest(reqtype, baseEndpoint+path, bytes.NewBuffer(body)) | ||
| req, err := http.NewRequest(reqtype, viper.GetString("endpoint")+path, bytes.NewBuffer(body)) |
There was a problem hiding this comment.
This should be coming from the config package so that you abstract the actual configuration backend.
Now the api package is coupled with the exact implementation that powers the configuration (viper).
It's probably a nitpick for a cli project though!
There was a problem hiding this comment.
While I kind of agree, that's how you're supposed to use Viper, or at least how most of the Go projects that use it seem to. Maybe I'll explore if there's a way to decouple them more cleanly than was done before
There was a problem hiding this comment.
Thanks for the feedback as always!
There was a problem hiding this comment.
Maybe I'll explore if there's a way to decouple them more cleanly than was done before
I was explaining how you could do this. Just get the information from the config package, without exposing the config backend being used.
You can check our internal project stats-components, for an example of what I'm saying.
Add function config command
No description provided.